Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support merge schema #2502

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 21, 2023

No description provided.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (3008fcf) 62.67% compared to head (f5305d1) 62.76%.
Report is 3 commits behind head on master.

Files Patch % Lines
internal/converter/json/converter.go 69.33% 22 Missing and 1 partial ⚠️
internal/topo/node/source_pool.go 57.89% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
+ Coverage   62.67%   62.76%   +0.09%     
==========================================
  Files         308      308              
  Lines       36618    36825     +207     
==========================================
+ Hits        22949    23112     +163     
- Misses      11552    11590      +38     
- Partials     2117     2123       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer marked this pull request as ready for review December 21, 2023 09:52
internal/topo/node/source_pool.go Outdated Show resolved Hide resolved
@Yisaer Yisaer requested a review from ngjaying December 25, 2023 02:59
@Yisaer Yisaer force-pushed the support_merge_schema_2 branch 3 times, most recently from 84a1efc to cc1e867 Compare December 26, 2023 08:35
Signed-off-by: yisaer <[email protected]>
@ngjaying ngjaying merged commit 9baf1e2 into lf-edge:master Dec 27, 2023
55 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jan 4, 2024
@ngjaying ngjaying added this to the 1.13 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants