Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: General pytorch function #3062

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

578223592
Copy link
Contributor

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 51.47059% with 66 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (8760def) to head (f7f3315).

Files with missing lines Patch % Lines
extensions/functions/mnist/mnist.go 53.49% 30 Missing and 10 partials ⚠️
extensions/functions/mnist/photoProcess.go 48.00% 22 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   71.01%   70.99%   -0.02%     
==========================================
  Files         392      394       +2     
  Lines       43959    44095     +136     
==========================================
+ Hits        31215    31303      +88     
- Misses      10261    10301      +40     
- Partials     2483     2491       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

578223592 and others added 24 commits September 12, 2024 00:15
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: Jiyong Huang <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: gexin.coder <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: guoguangwu <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: Jiyong Huang <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: coldWater <[email protected]>
Signed-off-by: Jiyong Huang <[email protected]>
Co-authored-by: coldWater <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
首个可以运行的版本

Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
@578223592 578223592 marked this pull request as ready for review September 13, 2024 17:56
@578223592
Copy link
Contributor Author

@ngjaying a small question about gci:
i have already install gci and run gci write --skip-generated -s standard -s default -s "prefix(github.com/lf-edge/ekuiper)" . like:
image
but the check still show:
e34db773165f3f63521dc22a23cb105

@@ -0,0 +1,2 @@
# include onnx c api
/usr/local/onnx/lib
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users need to install lib here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required, but it can also be installed in this directory. Perhaps I should remove it? @ngjaying

extensions/functions/onnx/onnx.go Outdated Show resolved Hide resolved
extensions/functions/onnx/onnx.go Outdated Show resolved Hide resolved
extensions/functions/onnx/onnx.json Show resolved Hide resolved
extensions/functions/onnx/onnx.go Outdated Show resolved Hide resolved
@578223592
Copy link
Contributor Author

@ngjaying the problem of gci still bothers me.
the gci show:

  Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run  --out-${NO_FUTURE}format line-number] in [/home/runner/work/ekuiper/ekuiper] ...
  internal/binder/mock/mock_factory.go:20: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/lf-edge/ekuiper/v2) (gci)
  	"github.com/lf-edge/ekuiper/contract/v2/api"
  extensions/functions/accumulateWordCount/accumulateWordCount.go:21: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/lf-edge/ekuiper/v2) (gci)
  	"github.com/lf-edge/ekuiper/contract/v2/api"
  pkg/message/mock.go:18: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/lf-edge/ekuiper/v2) (gci)
  	"github.com/lf-edge/ekuiper/contract/v2/api"
  Error: issues found
  Ran golangci-lint in 89659ms

i found extensions/functions/accumulateWordCount/accumulateWordCount.go:21: File is notgci-ed with --skip-generated -s standard -s default -s prefix(github.com/lf-edge/ekuiper/v2) (gci)
but when i run gci ,nothing changed , like:

➜  ekuiper git:(torch_dev_swx) gci write --skip-generated -s standard -s default -s "prefix(github.com/lf-edge/ekuiper)"  extensions/functions/accumulateWordCount/accumulateWordCount.go
➜  ekuiper git:(torch_dev_swx) git status
位于分支 torch_dev_swx
您的分支与上游分支 'origin/torch_dev_swx' 一致。

无文件要提交,干净的工作区
➜  ekuiper git:(torch_dev_swx) 

Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Signed-off-by: siwuxie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants