Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): server dynamic update route #3336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (9463f7d) to head (2eef739).

Files with missing lines Patch % Lines
internal/io/http/httpserver/data_server.go 66.67% 2 Missing and 1 partial ⚠️
internal/io/http/httpserver/websocket_server.go 66.67% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
- Coverage   71.13%   71.07%   -0.06%     
==========================================
  Files         399      399              
  Lines       45238    45254      +16     
==========================================
- Hits        32178    32162      -16     
- Misses      10539    10560      +21     
- Partials     2521     2532      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review October 28, 2024 01:50
@ngjaying ngjaying requested a review from Yisaer November 4, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant