Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Stable IPv6 addresses #2227

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eriknordmark
Copy link
Contributor

We switched to RFC7217 but are not setting a secret hence the IPv6 addresses differ on each boot.

@eriknordmark eriknordmark requested a review from rvs as a code owner August 12, 2021 19:35
@eriknordmark eriknordmark marked this pull request as draft August 12, 2021 19:35
Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be sitting on top of that other questionable PR. Any chance we can split those? (so that IPv6 stuff gets in separately) @eriknordmark ?

@eriknordmark eriknordmark force-pushed the cloud-init branch 2 times, most recently from 4f20c90 to 84c913c Compare August 24, 2021 08:32
@eriknordmark
Copy link
Contributor Author

this seems to be sitting on top of that other questionable PR. Any chance we can split those? (so that IPv6 stuff gets in separately) @eriknordmark ?

That was why it was a WIP/Draft. Cleaned it up. But need some tweak because the IPv6 addresses still change on EVE-OS reboot.

Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any reason not to merge this @eriknordmark ?

@eriknordmark
Copy link
Contributor Author

LGTM. Any reason not to merge this @eriknordmark ?

Yes, because it isn't sufficient. IPv6 addresses still change on every device reboot.

Signed-off-by: eriknordmark <[email protected]>
@rvs
Copy link
Contributor

rvs commented Nov 3, 2021

Hey @eriknordmark -- this has been open for quite a long time now -- any updates on what do you plan to do with this?

@@ -128,14 +131,48 @@ func addBridge(log *base.LogObject, ifname string) error {
log.Error(err)
return err
}
// update cached ifindex
// updatecached ifindex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to remove the space between "update" and "cached"?

@rouming
Copy link
Contributor

rouming commented Dec 5, 2022

Yes, because it isn't sufficient. IPv6 addresses still change on every device reboot

@eriknordmark Erik, I assume we need to set 'addr_gen_mode = 2' as well:

addr_gen_mode - INTEGER
         Defines how link-local and autoconf addresses are generated.

         0: generate address based on EUI64 (default)
         1: do no generate a link-local address, use EUI64 for addresses generated
            from autoconf
         2: generate stable privacy addresses, using the secret from
            stable_secret (RFC7217)
         3: generate stable privacy addresses, using a random secret if unset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants