[11.0 stable] Enhance LinuxCollector to support detecting multiple app VIF IPs #4257
Conversation
Application VIF may have multiple IP address assigned. They can be either assigned directly on the same interface, or used on separate VLAN sub-interfaces which share the parent interface MAC address. LinuxCollector should detect and publish all of them, instead of flapping between them and generating many IP address change notifications, which trigger a flood of NI and App info messages published to the controller. For DHCP assigned IP addresses, we use lease time to determine if a previously detected IP address is still valid. For statically assigned IP, we expect to see at least one associated ARP packet every 10 minutes. Otherwise, we consider the IP address to be removed or simply not used anymore. This commit also enhances LinuxCollector to support enabling or disabling ARP snooping in runtime, without requiring to recreate all switch network instances or rebooting device. Signed-off-by: Milan Lenco <[email protected]> (cherry picked from commit 5b2acf4)
milan-zededa
requested review from
rouming,
OhmSpectator and
eriknordmark
as code owners
|
The Eden test results look suspicious, I would say. |
Eden tests are very broken on 11.0 |
So, the only way to test the PR with any smoke tests is by ztests? |
OK, let's try this: #4260 |
|
As far as we do not have reliable Eden tests for this PR... should we just believe the PR is fine? ) |
Application VIF may have multiple IP address assigned. They can be either assigned directly on the same interface, or used on separate VLAN sub-interfaces which share the parent interface MAC address.
LinuxCollector should detect and publish all of them, instead of flapping between them and generating many IP address change notifications, which trigger a flood of NI and App info messages published to the controller.
For DHCP assigned IP addresses, we use lease time to determine if a previously detected IP address is still valid. For statically assigned IP, we expect to see at least one associated ARP packet every 10 minutes. Otherwise, we consider the IP address to be removed or simply not used anymore.
This commit also enhances LinuxCollector to support enabling or disabling ARP snooping in runtime, without requiring to recreate all switch network instances or rebooting device.
Signed-off-by: Milan Lenco [email protected]
(cherry picked from commit 5b2acf4)