bpftrace-compiler: add cache, loading kernel modules, fixes #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christoph-zededa
commented
Sep 17, 2024
•
christoph-zededa
commented
- 7e8649eaf config
- don't use 127.1 forwarding
- connect faster
- ensure current kernel works
- run tests in docker
- factory method for qemu runner
- generalize cobra cmds
- cleanup ssh/sftp client
- fix ssh auth
- introduce caching
- enable loading kernel modules
- improve error handling
- fix go.mod
christoph-zededa
changed the title
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_compiler-cache
branch
from
0508d74
to
68b8416
Compare
no patchlevel expected as by `gopls` Signed-off-by: Christoph Ostarek <[email protected]>
1 give some context to the error 2. if the user specified an unknown container type, it would not immediately fail, but instead give a confusing error message later Signed-off-by: Christoph Ostarek <[email protected]>
this is needed in order to build bpftrace scripts that use probes that come from modules Signed-off-by: Christoph Ostarek <[email protected]>
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_compiler-cache
branch
from
68b8416
to
a178d02
Compare
unfortunately compiling the bpftrace script can take a while, especially if userspace containers have to be included into the image Signed-off-by: Christoph Ostarek <[email protected]>
use one authenticator with several private ssh keys instead of several authenticators with one private ssh key now ssh auth should work even if the second key is used Signed-off-by: Christoph Ostarek <[email protected]>
remove unnecessary assignments - makes code more readable Signed-off-by: Christoph Ostarek <[email protected]>
allow userspace containers and loading kernel modules for all cobra commands generalize the usage of flags Signed-off-by: Christoph Ostarek <[email protected]>
instead of having the same code over and over, let's use a factory method Signed-off-by: Christoph Ostarek <[email protected]>
there it is possible to install qemu and run it Signed-off-by: Christoph Ostarek <[email protected]>
a new test that checks kernel-commits.mk and does a basic test to check that the kernel supports bpftrace Signed-off-by: Christoph Ostarek <[email protected]>
by immediate breaking the reconnect loop if the connect try was successful Signed-off-by: Christoph Ostarek <[email protected]>
but use localhost, because this works even since before commit 455bf4b Signed-off-by: Christoph Ostarek <[email protected]>
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_compiler-cache
branch
from
a178d02
to
50ba49e
Compare
rouming
reviewed
Sep 23, 2024
eve-tools/bpftrace-compiler/main.go
Outdated
| @@ -241,6 +241,7 @@ func newEdgeviewCmd() *cobra.Command { | |||
| time.Sleep(time.Second) | |||
| continue | |||
| } | |||
| break | |||
| } | |||
|
|
|||
| hr := newHTTPRun(fmt.Sprintf("localhost:%d", port)) | |||
There was a problem hiding this comment.
Can be previous loop was not successful, should we fail here with an error if so?
Also 127.0.0.0 in the loop above and here is localhost. Not a big deal, but why not to make them identical?
There was a problem hiding this comment.
I added bd95726
rouming
approved these changes
Sep 23, 2024
otherwise it will leak mem and/or filedescriptor Signed-off-by: Christoph Ostarek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.