Properly initialize AppNetworkStatus after invalid config was fixed #4267
+51
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
added
bug
europaul
approved these changes
Sep 19, 2024
eriknordmark
approved these changes
Sep 19, 2024
milan-zededa
force-pushed
the
fix-app-net-modify
branch
from
f5541e5
to
841b75b
Compare
Done (11.5.0) |
When the application network configuration fails validation, the AppNetworkStatus will be marked with an error, while the AppNum and MACGenerator fields will remain unset. If the user corrects the invalid part of the configuration, the handleAppNetworkModify callback will be triggered, and validation will succeed. However, before activating the application network, the zedrouter must ensure that AppNum and MACGenerator are initialized. Otherwise, the zedbox will panic with a fatal error: "undefined MAC generator." Issue addressed by this patch was introduced in version 11.5.0 Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
fix-app-net-modify
branch
from
841b75b
to
4705b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application network configuration fails validation, the
AppNetworkStatuswill be marked with an error, while theAppNumandMACGeneratorfields will remain unset. If the user corrects the invalid part of the configuration, thehandleAppNetworkModifycallback will be triggered, and validation will succeed. However, before activating the application network, the zedrouter must ensure thatAppNumandMACGeneratorare initialized. Otherwise, zedbox process will panic with a fatal error:undefined MAC generatorIssue addressed by this patch was introduced in version 11.5.0