vtpm fix : use domain uuid instead of full domain name #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
approved these changes
Sep 18, 2024
Config Num comes from the cloud. They increase it with each config update. |
|
The virtualization test suite has failed three times. Strange. |
|
Yeah, it looks like something is broken... |
It is the version number (and not the app number) which is changed, right? If so it makes sense to update the PR description. |
pkg/pillar/hypervisor/kvm.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("failed to extract UUID from domain name: %v", err) | ||
| } | ||
| return requestVtpmLaunch(domainUUID.String(), wk, swtpmTimeout) |
There was a problem hiding this comment.
Nit, but if the argument type was uuid.UUID and not a string then the compiler would help check.
|
@shjala, will you take a look at why the same Eden test fails all the time? |
All are green except virtualization, do you mean that or there is more? |
|
Yeah, I mean that one. I don't see the same test failing in other PRs all the time. Maybe it's just a coincidence, but it's better to check. |
Domain name contains UUID, version and app number, the version number might get changed, so use only the UUID part to presever the vtpm state. Signed-off-by: Shahriyar Jalayeri <[email protected]>
|
@OhmSpectator should be fixed now, rerun? |
|
All green! What exactly have you done? Just rebase? |
shjala
commented
Sep 23, 2024
Eden rerun is appreciated. |
OhmSpectator
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain name contains UUID, version and app number,the version number might get changed, so use only the
UUID part to preserve the vtpm state.
This PR is based on a observation in @OhmSpectator code comment :
I'll be happy if someone point me to part of the code that actually makes this change to
appversion number, I couldn't find it myself.