-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add sticky position to CollapsibleHeader #749
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
@Gabriel-Bueno32 is attempting to deploy a commit to the ROUTE06 Core Team on Vercel. A member of the Team first needs to authorize it. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😄
.../ERDRenderer/ERDContent/TableNode/TableDetail/CollapsibleHeader/CollapsibleHeader.module.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM! I apologize for the inconvenience, but could you please address the conflict?🙏 (because we moved the CollapsibleHeader.module.css
file)
If it is difficult to handle, please let me know and I will create a pull request on my end!
User description
Related Issue
#741
Testing
2025-02-17.18-07-48.mov
2025-02-17.18-09-10.mov
PR Type
Bug fix
Description
Added
position: sticky
toCollapsibleHeader
for desktop.Ensured header sticks to the top during scrolling.
Changes walkthrough 📝
CollapsibleHeader.module.css
Add sticky positioning to CollapsibleHeader CSS
frontend/packages/erd-core/src/components/ERDRenderer/ERDContent/TableNode/TableDetail/CollapsibleHeader/CollapsibleHeader.module.css
position: sticky
to.header
class.