Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project name to "Liam ERD" in README and components #788

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Feb 27, 2025

User description

Unify service names since Liam and Liam ERD are mixed up.


PR Type

Documentation, Enhancement


Description

  • Updated project name to "Liam ERD" across components and documentation.

  • Modified aria-label in LiamLogo component for consistency.

  • Updated title in CookieConsent component to reflect new name.

  • Adjusted README to use "Liam ERD" in headings and license section.


Changes walkthrough 📝

Relevant files
Enhancement
LiamLogo.tsx
Update `aria-label` in `LiamLogo` component                           

frontend/apps/docs/components/LiamLogo/LiamLogo.tsx

  • Updated aria-label from "Liam Logo" to "Liam ERD Logo".
+1/-1     
CookieConsent.tsx
Update title in `CookieConsent` component                               

frontend/packages/ui/src/components/CookieConsent/CookieConsent.tsx

  • Changed title from "Liam Cookie Consent" to "Liam ERD Cookie Consent".
  • +1/-1     
    Documentation
    README.md
    Update README to reflect "Liam ERD"                                           

    README.md

  • Updated alt text in logo images to "Liam ERD".
  • Changed project name references to "Liam ERD".
  • +3/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    vercel bot commented Feb 27, 2025

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    liam-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 3:06am
    liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 3:06am
    3 Skipped Deployments
    Name Status Preview Comments Updated (UTC)
    test-liam-docs ⬜️ Ignored (Inspect) Feb 27, 2025 3:06am
    test-liam-erd-sample ⬜️ Ignored (Inspect) Feb 27, 2025 3:06am
    test-liam-erd-web ⬜️ Ignored (Inspect) Feb 27, 2025 3:06am

    Copy link

    changeset-bot bot commented Feb 27, 2025

    ⚠️ No Changeset found

    Latest commit: 91b7c13

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    CI Feedback 🧐

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: run-e2e / e2e-test (Mobile Safari)

    Failed stage: Run e2e tests [❌]

    Failed test name: [Mobile Safari] › tests/vrt/vrt.test.ts › top

    Failure summary:

    The action failed due to a Visual Regression Test (VRT) failure in Mobile Safari:

  • The test 'top' failed because the screenshot comparison did not match the expected result
  • The test was retried 2 times but continued to fail
  • The test generated diff images showing the visual differences between expected and actual results
  • The failure occurred in the file 'tests/vrt/vrt.test.ts' at line 21

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    179:  Scope: all 11 workspace projects
    180:  Lockfile is up to date, resolution step is skipped
    181:  Progress: resolved 1, reused 0, downloaded 0, added 0
    182:  Packages: +1440
    183:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    184:  Progress: resolved 1440, reused 1286, downloaded 0, added 0
    185:  Progress: resolved 1440, reused 1420, downloaded 0, added 760
    186:  Progress: resolved 1440, reused 1420, downloaded 0, added 1440, done
    187:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'
    ...
    
    192:  + @turbo/gen 2.1.2
    193:  + syncpack 13.0.0
    194:  + turbo 2.1.2
    195:  frontend/apps/docs postinstall$ fumadocs-mdx
    196:  frontend/apps/docs postinstall: [MDX] types generated
    197:  frontend/apps/docs postinstall: Done
    198:  frontend/apps/erd-web postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
    199:  frontend/apps/erd-web postinstall: Done
    200:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'
    ...
    
    1379:  env:
    1380:  CI: true
    1381:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    1382:  URL: https://liam-erd-g7hr0e7qv-route-06-core.vercel.app
    1383:  ##[endgroup]
    1384:  Running 17 tests using 1 worker
    1385:  °°°·°······°°°°°××F
    1386:  1) [Mobile Safari] › tests/vrt/vrt.test.ts:21:5 › top ────────────────────────────────────────────
    1387:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    ...
    
    1418:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1419:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1420:  test-results/vrt-vrt-top-Mobile-Safari/top-1-actual.png
    1421:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1422:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1423:  test-results/vrt-vrt-top-Mobile-Safari/top-1-diff.png
    1424:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1425:  Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    1426:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    ...
    
    1462:  test-results/vrt-vrt-top-Mobile-Safari-retry1/top-1-diff.png
    1463:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1464:  attachment #4: trace (application/zip) ─────────────────────────────────────────────────────────
    1465:  test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip
    1466:  Usage:
    1467:  pnpm exec playwright show-trace test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip
    1468:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1469:  Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    1470:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    ...
    
    1503:  test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-actual.png
    1504:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1505:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1506:  test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-diff.png
    1507:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1508:  Slow test file: [Mobile Safari] › tests/e2e/toolbar.test.ts (55.9s)
    1509:  Slow test file: [Mobile Safari] › tests/e2e/page.test.ts (25.5s)
    1510:  Consider running tests from slow files in parallel, see https://playwright.dev/docs/test-parallel.
    1511:  1 failed
    1512:  [Mobile Safari] › tests/vrt/vrt.test.ts:21:5 › top ─────────────────────────────────────────────
    1513:  9 skipped
    1514:  7 passed (2.1m)
    1515:  ##[error]Process completed with exit code 1.
    

    Copy link
    Member

    @FunamaYukina FunamaYukina left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you for your response, just one comment.🙏

    Copy link
    Member

    @FunamaYukina FunamaYukina left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!!

    @FunamaYukina FunamaYukina added this pull request to the merge queue Feb 27, 2025
    Merged via the queue into main with commit dd4ee3a Feb 27, 2025
    20 checks passed
    @FunamaYukina FunamaYukina deleted the update-to-liam-erd branch February 27, 2025 07:34
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants