-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 integrate user editing state into related tables component #798
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5c06c79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Issue
Why is this change needed?
I would like to be able to select a series of tables and still see the related tables correctly, but The first selected related tables are displayed.
What would you like reviewers to focus on?
I added key props so that RelatedTables re-renders when the selected table changes.
Testing Verification
ss.65.mov
2025-02-28.17.49.11.mov
What was done
🤖 Generated by PR Agent at 5c06c79
useUserEditingActiveStore
to track active table state.key
prop to force re-rendering ofRelatedTables
component.Detailed Changes
RelatedTables.tsx
Ensure `RelatedTables` updates on table selection change
frontend/packages/erd-core/src/features/erd/components/ERDContent/components/TableNode/TableDetail/RelatedTables/RelatedTables.tsx
useUserEditingActiveStore
to track active table state.key
prop toERDContent
to trigger re-render on table change.tableName
from the store to ensure correct table rendering.empty-baboons-doubt.md
Document changes for related tables bug fix
.changeset/empty-baboons-doubt.md
Additional Notes