Gate out test functions that use probe! on ppc64le and s390x #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These require `feature(asm_experimental_arch)` which only works on nightly compilers. See rust-lang/rust#93335 Also loosen version requirement on `probe`; on Fedora we have been building with `probe` 0.5.1 with no issue. Tested by doing a scratch build on Fedora's Koji build system: https://koji.fedoraproject.org/koji/taskinfo?taskID=123361398 Signed-off-by: Michel Lind <[email protected]>
michel-slm
force-pushed
the
probe-fixes
branch
from
6a74e1f
to
00dcfb9
Compare
michel-slm
changed the title
d-e-s-o
reviewed
Sep 16, 2024
| @@ -48,7 +48,7 @@ libbpf-rs = {path = ".", features = ["generate-test-files"]} | |||
| log = "0.4.4" | |||
| memmem = "0.1.1" | |||
| plain = "0.2.3" | |||
| probe = "0.3" | |||
| probe = ">=0.3, <0.6" | |||
There was a problem hiding this comment.
Let's just bump to 0.5 then? Nobody is really testing any version ranges, so this is hard to test for correctness. It's also very atypical for Rust projects from what I understand.
| @@ -9,7 +9,6 @@ use libbpf_rs::ObjectBuilder; | |||
| use libbpf_rs::OpenObject; | |||
| use libbpf_rs::ProgramMut; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Would you mind reverting the spurious formatting change?
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days. |
|
Closing pull request as it is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These require
feature(asm_experimental_arch)which only works on nightly compilers.See rust-lang/rust#93335
Also loosen version requirement on
probe; on Fedora we have been building withprobe0.5.1 with no issue.Tested by doing a scratch build on Fedora's Koji build system:
https://koji.fedoraproject.org/koji/taskinfo?taskID=123361398