Identify agent version #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
reviewed
Jan 19, 2023
| @@ -35,6 +39,8 @@ namespace libp2p::injector { | |||
| di::bind<protocol::SchedulerConfig>.template to(protocol::SchedulerConfig {}), | |||
| di::bind<protocol::Scheduler>.template to<protocol::AsioScheduler>(), | |||
|
|
|||
| di::bind<Libp2pClientVersion>.template to(Libp2pClientVersion{"libp2p"}), | |||
There was a problem hiding this comment.
How about 'cpp-libp2p'? There are exist more then one libp2p implementations
xDimon
reviewed
Jan 19, 2023
| @@ -175,7 +175,9 @@ namespace libp2p::protocol::gossip { | |||
| MessageId msg_id = create_message_id_(msg->from, msg->seq_no, msg->data); | |||
|
|
|||
| [[maybe_unused]] bool inserted = msg_cache_.insert(msg, msg_id); | |||
There was a problem hiding this comment.
Suggested change
| [[maybe_unused]] bool inserted = msg_cache_.insert(msg, msg_id); | |
| bool inserted = msg_cache_.insert(msg, msg_id); |
xDimon
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make identify agent version configurable