Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extensible peer ids #2496

Merged
merged 5 commits into from
Apr 24, 2024
Merged

feat: extensible peer ids #2496

merged 5 commits into from
Apr 24, 2024

Conversation

achingbrain
Copy link
Member

Sometimes a peer will have a non-cryptographic identifier such as a URL.

Update the PeerId type to be an interface so we can use arbitrary data to identify other peers, not just cryptographic keys.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Sometimes a peer will have a non-cryptographic identifier such as
a URL.

Update the PeerId type to be an interface so we can use arbitrary
data to identify other peers, not just cryptographic keys.
packages/crypto/src/keys/index.ts Outdated Show resolved Hide resolved
packages/crypto/src/keys/index.ts Outdated Show resolved Hide resolved
packages/crypto/src/keys/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor issues in comments. otherwise looks pretty straightforward.

packages/crypto/src/keys/index.ts Show resolved Hide resolved
packages/interface/src/peer-id/index.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 0d5d966 into main Apr 24, 2024
22 checks passed
@achingbrain achingbrain deleted the feat/extensible-peer-ids branch April 24, 2024 08:09
@achingbrain achingbrain mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants