Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add peer filter #2508

Merged
merged 6 commits into from
Apr 26, 2024
Merged

feat: add peer filter #2508

merged 6 commits into from
Apr 26, 2024

Conversation

achingbrain
Copy link
Member

To make filtering peers in a memory-efficient way possible, add a peer filter based on a bloom filter using the binary representation of the peer id.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add bloom filter
bd93469 
Adds a bloom filter implementation to `@libp2p/utils` for use in
libp2p components.
@achingbrain
Merge remote-tracking branch 'origin/main' into feat/add-bloom-filter
73245e7
@achingbrain
feat: add peer filter to collections module
1d98d7b 
To make filtering peers in a memory-efficient way possible, add a
peer filter based on a bloom filter using the binary represeentation
of the peer id.
@achingbrain achingbrain requested a review from a team as a code owner April 26, 2024 17:05
@achingbrain achingbrain changed the title feat: add bloom filter feat: add peer filter Apr 26, 2024
Base automatically changed from feat/add-bloom-filter to main April 26, 2024 17:10
SgtPooki
SgtPooki approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@achingbrain achingbrain merged commit 4afd7a9 into main Apr 26, 2024
22 checks passed
@achingbrain achingbrain deleted the feat/add-peer-filter branch April 26, 2024 19:13
@achingbrain achingbrain mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @SgtPooki @maschad