Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/racer endpoint #54

Merged
merged 8 commits into from
Oct 31, 2023

Conversation

Anupya
Copy link
Contributor

@Anupya Anupya commented Oct 22, 2023

Description

  • Implement create_race = /api/racer endpoint.
  • Rename id to more clear puzzle_id since id shadows the built-in id (could be breaking 🚨)
  • Rename max to max_entries since max shadows the built-in max (could be breaking 🚨)
  • high score is two words!

After merge

Please check off /api/racer in issue description #6.

@Anupya Anupya marked this pull request as ready for review October 22, 2023 05:27
@benediktwerner
Copy link
Member

I don't think it's worth changing the parameter names given that it could be a breaking change.

And as mentioned in #50, ideally the return types of new endpoints should be typed using TypedDict.

@Anupya Anupya force-pushed the Anupya/add-puzzle-race-endpoint branch from 418cf01 to d323d23 Compare October 30, 2023 14:24
@kraktus kraktus merged commit 217616d into lichess-org:master Oct 31, 2023
19 checks passed
@kraktus
Copy link
Member

kraktus commented Oct 31, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants