Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /api/external_engine endpoints #58

Merged

Conversation

Anupya
Copy link
Contributor

@Anupya Anupya commented Oct 22, 2023

Description

Implements the following:

  • get = GET /api/external-engine
  • get_by_id = /api/external-engines/{id}
  • create = POST /api/external-engine
  • update = PUT /api/external-engine
  • delete = DEL /api/external-engine

Note that this PR does NOT include any of the endpoints that use a different domain than https://lichess.org.

After merge

Please check off the above endpoints in the issue description for #6 🙏

@benediktwerner
Copy link
Member

Same as #50, if possible, please use typed dicts for return types.

On a side note, maybe also would be nice to mention whether and which authorization is required for an endpoint. It's usually mentioned in the Lichess API docs under "Authorization".

@Anupya
Copy link
Contributor Author

Anupya commented Oct 27, 2023

Please review!

@Anupya Anupya force-pushed the Anupya/add-external-engine-endpoints branch from 2a7df16 to cf8956a Compare October 30, 2023 14:25
@kraktus kraktus force-pushed the Anupya/add-external-engine-endpoints branch from cf8956a to 6972222 Compare October 31, 2023 23:01
@kraktus
Copy link
Member

kraktus commented Oct 31, 2023

Thanks! Nice work

@kraktus kraktus merged commit 8ad315c into lichess-org:master Oct 31, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants