Fix Missing Learn from Mistakes Next button on Mobile #17052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next button is way too low to be displayed on most screens, I assume. It should be displayed alongside "Good move" instead of below it. |
ornicar
requested review from
brollin and
Copilot
and removed request for
brollin
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
brollin
reviewed
Feb 27, 2025
| @@ -77,7 +77,7 @@ body { | |||
| margin: $analyse-block-gap 0 0 0; | |||
| } | |||
|
|
|||
| grid-template-rows: auto auto auto minmax(20em, 30vh); | |||
| grid-template-rows: auto auto auto minmax(20em, 36vh); | |||
There was a problem hiding this comment.
In the firefox dev tools, I picked iPhone SE 2nd gen in device selector and saw this. Choosing a maximum height for this grid area that scales based on viewport height when the div is not scrollable might not be best, but adding another nested scrolling area clearly isn't preferable. So not sure how to fix besides bumping up this number or changing its units. Looks like 40vh works all right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increases the height row height of the analyse tools grid so that the Next button is visible on mobile with 5 engine lines enabled.
Before
After