Add transform for SameRunTime trait #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this We can have a better ergonomic code with implicit context, which We use exclusively for SameRuntime in lila. for example, with this PR We can refactor as follow: ```diff extension [A](m: Mapping[A]) - def into[B](using sr: SameRuntime[A, B], rs: SameRuntime[B, A]): Mapping[B] = - m.transform(sr.apply, rs.apply) + def into[B](using SameRuntime[A, B], SameRuntime[B, A]): Mapping[B] = + m.transform(_.transform, _.transform) ``` (Refactor for https://github.com/lichess-org/lila/blob/master/modules/common/src/main/Form.scala#L287-L289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this We can have a better ergonomic code with implicit context, which We use exclusively for SameRuntime in lila. for example, with this PR We can refactor as follow:
(Refactor for https://github.com/lichess-org/lila/blob/master/modules/common/src/main/Form.scala#L287-L289)