Optimize RandomApi::nextString #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacl
force-pushed
the
fasterNextString
branch
from
28401ba to
1abc842
Compare
isaacl
force-pushed
the
fasterNextString
branch
from
1abc842 to
611cd73
Compare
isaacl
force-pushed
the
fasterNextString
branch
3 times, most recently
from
d95654a to
6589ed2
Compare
The test isn't meaningful anymore. ThreadLocalRandom uses a singleton interface so it's not possible to check that different threads are using a different instance.
The test isn't meaningful anymore. ThreadLocalRandom uses a singleton interface so it's not possible to check that different threads are using a different instance.
Avoid boxing of int (for comprehension) and char (with the scala StringBuilder). Use an Array instead of capacity specified StringBuilder. Generally it's faster to use java StringBuilder instead of the scala StringBuilder wrapper. But Arrays are even faster when you know the length in advance. Side note: Random.nextInt is twice as fast for powers of 2, so if we expanded characters to 64 instead of 62, this method could be even faster. Also: - Clean up oneOf - Optimize odds
isaacl
force-pushed
the
fasterNextString
branch
from
6589ed2 to
5f734e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid boxing of int (for comprehension) and char (with the scala StringBuilder). Use an Array instead of capacity specified StringBuilder.
Generally it's faster to use java StringBuilder instead of the scala StringBuilder wrapper. But Arrays are even faster when you know the length in advance.
Side note: Random.nextInt is twice as fast for powers of 2, so if we expanded characters to 64 instead of 62, this method could be even faster.