Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] stake populate tx #103

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[Fix] stake populate tx #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d17dc4
fix: remove gas calculation from stake populate
Jeday Jan 26, 2024
bddde3c
docs: changelog
Jeday Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

- better multisig behavior for transactions
- Simulate methods now have correct return types
- `stakeEthPopulateTx` not does not calculate `gasLimit` which prevented usage when stake limit is reached

## Playground

Expand Down
5 changes: 0 additions & 5 deletions packages/sdk/src/stake/stake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,10 @@ export class LidoSDKStake extends LidoSDKModule {
const { referralAddress, value, account } = await this.parseProps(props);
const data = this.stakeEthEncodeData({ referralAddress });
const address = await this.contractAddressStETH();
const gas = await this.submitGasLimit(value, referralAddress, {
account,
chain: this.core.chain,
});
return {
to: address,
from: account.address,
value,
gas,
data,
};
}
Expand Down