[0.1] Cut 0.1.2 #3698
[0.1] Cut 0.1.2 #3698
Conversation
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
| model. Note that by default historical buckets are only decayed if no new | ||
| datapoints have been added for a channel for two weeks (#3562). |
There was a problem hiding this comment.
Is this new behavior after the fix? The commit message is pretty sparse on details bb468dd
There was a problem hiding this comment.
No, that was existing (but is configurable)
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Ah benchmark is failing |
lightning-liquidity/Cargo.toml
Outdated
| @@ -38,6 +38,7 @@ lightning-background-processor = { version = "0.1.0", path = "../lightning-backg | |||
|
|
|||
| proptest = "1.0.0" | |||
| tokio = { version = "1.35", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] } | |||
| parking_lot = { version = "0.12", default-features = false } | |||
There was a problem hiding this comment.
If we're willing to take on that dependency, why not just drop all the different cases and use parking_lot types everywhere? IIRC it would have additional benefits, including that it offers RwLockReadGuard variants that could potentially be held across await boundaries?
There was a problem hiding this comment.
I'm not super happy taking it as a dependency, no, just a dev one.
it offers RwLockReadGuard variants that could potentially be held across await boundaries?
We shouldn't be doing that to begin with...
TheBlueMatt
force-pushed
the
2025-04-0.1.2-relnotes
branch
from
2bc944c to
c0866f5
Compare
TheBlueMatt
force-pushed
the
2025-04-0.1.2-relnotes
branch
from
c0866f5 to
4b90166
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.1 #3698 +/- ##
==========================================
- Coverage 88.41% 88.39% -0.02%
==========================================
Files 149 149
Lines 113859 113859
Branches 113859 113859
==========================================
- Hits 100663 100648 -15
- Misses 10744 10753 +9
- Partials 2452 2458 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Depends on #3697 for now