Skip to content

Commit

Permalink
Merge pull request #2873 from AkihiroSuda/portfwd-fix-wrong-comment
Browse files Browse the repository at this point in the history
test-templates.sh: fix wrong comment "binds to 0.0.0.0 by default"
  • Loading branch information
jandubois authored Nov 8, 2024
2 parents 474eec4 + 568f16f commit 7df86f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hack/test-templates.sh
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ if [[ -n ${CHECKS["port-forwards"]} ]]; then
"${scriptdir}/test-port-forwarding.pl" "${NAME}"

if [[ -n ${CHECKS["container-engine"]} || ${NAME} == "alpine"* ]]; then
INFO "Testing that \"${CONTAINER_ENGINE} run\" binds to 0.0.0.0 by default and is forwarded to the host"
INFO "Testing that \"${CONTAINER_ENGINE} run\" binds to 0.0.0.0 and is forwarded to the host (non-default behavior, configured via test-port-forwarding.pl)"
if [ "$(uname)" = "Darwin" ]; then
# macOS runners seem to use `localhost` as the hostname, so the perl lookup just returns `127.0.0.1`
hostip=$(system_profiler SPNetworkDataType -json | jq -r 'first(.SPNetworkDataType[] | select(.ip_address) | .ip_address) | first')
Expand Down

0 comments on commit 7df86f9

Please sign in to comment.