Removing ambry-coordinator #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes all usages of Coordinator and removes Coordinator code
vgkholla
commented
Sep 15, 2016
| } | ||
| } | ||
| }; | ||
| TestFuture<GetBlobResult> testFuture = |
There was a problem hiding this comment.
only formatting changes.
| @@ -1,170 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
removed this because it is unused and migrating it to the Router was unnecessary right now. There is already an issue (#383) to write a more comprehensive migrator service. I can like this PR to the issue in case someone wants to see what was available.
pnarayanan
approved these changes
Sep 16, 2016
| @@ -271,7 +267,6 @@ private static PutResponse getPutResponseFromStream(ConnectedChannel blockingCha | |||
|
|
|||
| public static void main(String args[]) { | |||
| FileWriter writer = null; | |||
| AmbryCoordinator coordinator = null; | |||
There was a problem hiding this comment.
This was just lying in here? The coordinator had no purpose in this tool?
cgtz
approved these changes
Sep 16, 2016
vgkholla
force-pushed
the
coordinatorRemove
branch
from
eb3f143 to
ff346f5
Compare
|
Built on mac and linux. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all usages of
Coordinatorand removesCoordinatorcodeBuilt and formatted.
Primary reviewers: @pnarayanan, @cgtz
Expected time to review: 20-30 mins
Addresses #432.