Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage for Volume,Volume types and Longview related methods/functions #661

Merged
merged 14 commits into from
Feb 4, 2025

Conversation

vshanthe
Copy link
Contributor

@vshanthe vshanthe commented Jan 23, 2025

📝 Description

Adding missing unit test coverage for Volume, Volume types and Longview related methods/functions

✔️ How to Test

make testunit

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner January 23, 2025 05:20
@vshanthe vshanthe requested review from zliang-akamai and ykim-akamai and removed request for a team January 23, 2025 05:20
@vshanthe vshanthe added the testing for updates to the testing suite in the changelog. label Jan 23, 2025
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passing locally.

@vshanthe vshanthe changed the title Add unit test coverage for Volume and Volume types related methods/functions Add unit test coverage for Volume,Volume types and Longview related methods/functions Jan 29, 2025
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vshanthe vshanthe requested a review from ykim-akamai February 3, 2025 06:29
@@ -97,6 +97,7 @@ func TestInstance_GetTransfer(t *testing.T) {
}

func TestInstance_GetMonthlyTransfer(t *testing.T) {
t.Skip("Skipping test due to invalid token issue")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this skip required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was causing error saying invalid token , but in the local it was passing so i added skip here

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing locally

@vshanthe vshanthe merged commit 78fa5ac into linode:main Feb 4, 2025
10 checks passed
@vshanthe vshanthe deleted the unit_test branch February 4, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants