-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test coverage for Volume,Volume types and Longview related methods/functions #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tests passing locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -97,6 +97,7 @@ func TestInstance_GetTransfer(t *testing.T) { | |||
} | |||
|
|||
func TestInstance_GetMonthlyTransfer(t *testing.T) { | |||
t.Skip("Skipping test due to invalid token issue") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this skip required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was causing error saying invalid token , but in the local it was passing so i added skip here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests passing locally
📝 Description
Adding missing unit test coverage for Volume, Volume types and Longview related methods/functions
✔️ How to Test
make testunit
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.