Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs_panel.py: Error handling for panels on unavailable monitors #12399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MellowKyler
Copy link

If a panel definition exists for an inactive monitor, launching the panels settings menu will fail.

In id_or_monitor_position_used we check if a position is used by going through monitor_layout[monitor_id]. This can result in an index out of range error if the length of monitor_layout is not greater than monitor_id. See #12378 and #12397.

To reproduce:

  1. Go to the display settings menu and disable a monitor with a panel (or simply unplug a monitor with a panel)
  2. Attempt to launch the panels settings menu

This implementation does not remove the panel definition and it will still be available when the monitor is re-attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant