Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 3.11.2 - Update default ddclient.conf #96

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kylmp
Copy link
Contributor

@kylmp kylmp commented Jan 6, 2025

Missing some new defaults added since 3.10.0 in the default ddclient.conf file (ddclient/ddclient@v3.10.0...v3.11.2)

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Default config file is messing new ddns routers

Benefits of this PR and context:

The ddclient version deployed (3.11.2) has new defaults than was is included in here, it should match with ddclient

How Has This Been Tested?

added the porkbun details locally and can verify it works as expected, other routers untested

Source / References:

ddclient/ddclient@v3.10.0...v3.11.2

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-e1b4c1e7-dev-c7d4d3a296e492587962e2073a43a94693a8863d-pr-96/index.html
https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-e1b4c1e7-dev-c7d4d3a296e492587962e2073a43a94693a8863d-pr-96/shellcheck-result.xml

Tag Passed
amd64-v3.11.2-pkg-e1b4c1e7-dev-c7d4d3a296e492587962e2073a43a94693a8863d-pr-96
arm64v8-v3.11.2-pkg-e1b4c1e7-dev-c7d4d3a296e492587962e2073a43a94693a8863d-pr-96

@thespad thespad merged commit 5d2c10e into linuxserver:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants