Fixed package descriptions for firefox-fonts mod #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR build pushed to |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes issue #1007 by using the correct package names for downloading the extra fonts. I also corrected the command for checking if the mod has already been installed. Note that this does not address the deprecation warning, but it does restore the intended functionality to the firefox-fonts mod.
Benefits of this PR and context:
This PR enables users of the firefox-fonts mod to have CJK fonts automatically installed in their firefox container, whereas before this functionality was broken. This fixes issue #1007, but does so without addressing the deprecation warning, because the "mozillateam" PPA has nothing to do with the firefox-fonts mod and must be fixed in the docker-firefox repository.
How Has This Been Tested?
.github/workflows/BuildImage.yml.sigptr/mods:firefox-fontson Dockerhub.DOCKER_MODSvariable tosigptr/mods:firefox-fontsfirefox-fonts-mergebranch, taking care to only include the actual changes and not the CI modifications I used for testing.Source / References:
#1007