Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for instructions #1

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Fix for instructions #1

merged 10 commits into from
Sep 30, 2024

Conversation

fyliu
Copy link
Contributor

@fyliu fyliu commented Sep 29, 2024

  • fixed some typos and grammar
  • added missing import instructions

Please feel free to do whatever you like with this. For the most part, your tutorial just works!

I didn't finish watching your DjangoCon video, but it's clear you're very knowledgeable about the technology and quick at solving technical issues. I love how well you organized the section titles. Very clean! I also like that you switched from poetry to uv. I also made the same choice and I really want to switch when I have time, just for the lower initial dependency factor. I wrote a similar guide for onboarding new developers and I see you made similar choices in formatting your code explanations, but I also see and like your technique for introducing more than one way of writing serializers and views. Thank you for putting this together!

@lipemorais
Copy link
Owner

Thanks for this PR @fyliu ! 🥳

@lipemorais lipemorais merged commit 6edc2fd into lipemorais:main Sep 30, 2024
@lipemorais lipemorais self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants