Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blacksheep #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix blacksheep #36

wants to merge 1 commit into from

Conversation

euri10
Copy link

@euri10 euri10 commented Feb 8, 2024

Pull Request Checklist

  • New code has 100% test coverage
  • [x ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Close Issue(s)

blacksheep container was not starting

@euri10 euri10 requested review from a team as code owners February 8, 2024 09:00
@euri10
Copy link
Author

euri10 commented Feb 8, 2024

the CI may fail because of cached dpeendencies, see https://github.com/Neoteroi/rodi/blob/f6d6fbc36add536862f7c98feaf3f22270e352ac/rodi/__init__.py#L1068

@JacobCoffee
Copy link
Member

AttributeError: 'Container' object has no attribute '_add_exact_scoped'

@euri10
Copy link
Author

euri10 commented Feb 22, 2024

AttributeError: 'Container' object has no attribute '_add_exact_scoped'

well I think the method is private now: https://github.com/Neoteroi/rodi/blob/f6d6fbc36add536862f7c98feaf3f22270e352ac/rodi/__init__.py#L1068
but I can be wrong :)
that's why I thought this was a cahe issue in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee JacobCoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euri10 @JacobCoffee