Merge pull request #786 from dhruvmisra/fix/userExistsALert

[Issue #580 fix] Added username check on the first screen
llaske · May 2, 2020 · c9e3f8f · c9e3f8f
2 parents fa452ad + ddfb499
commit c9e3f8f
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 5 deletions.
diff --git a/js/firstscreen.js b/js/firstscreen.js
@@ -254,9 +254,14 @@ enyo.kind({
 			if (name.length == 0) {
 				return;
 			}
-			this.step++;
+
 			if (util.getClientType() == constant.appType && (this.createnew || !this.$.server.getValue())) { // No password for the app when create new or server is null
+				this.step += 2;
+				this.displayStep();
+			} else if(!this.createnew) {  // Login
 				this.step++;
+			} else {  // Signup
+				this.checkUsername(name);
 			}
 			this.displayStep();
 		} else if (this.step == 3) {
@@ -423,6 +428,43 @@ enyo.kind({
 		}
 	},
 
+	checkUsername: function(name) {
+		var that = this;
+		that.$.spinner.setShowing(true);
+		myserver.postUser(
+			{
+				name: name,
+				role: "student",
+				beforeSignup: true
+			},
+			function(inSender, inResponse) {
+				if(!inResponse.exists) {
+					// Username unique
+					that.step++;
+					that.displayStep();
+				}
+				that.$.spinner.setShowing(false);
+			},
+			function(response, error) {
+				if(error == 2) {
+					// Server does not support fix -> old workflow
+					that.step++;
+					that.displayStep();
+				} else {
+					// Server supports fix -> new workflow
+					if(error == 22) {
+						// Username already exists
+						that.$.warningmessage.setContent(l10n.get("UserAlreadyExist"));
+					} else {
+						that.$.warningmessage.setContent(l10n.get("ServerError", {code: error}));
+					}
+					that.$.warningmessage.setShowing(true);
+				}
+				that.$.spinner.setShowing(false);
+			}
+		);
+	},
+
 	createUser: function() {
 		var that = this;
 		myserver.postUser(

diff --git a/lib/server.js b/lib/server.js
@@ -148,10 +148,12 @@ define(["settings"], function(preferences) {
 			}
 		});
 		ajax.response(function(inSender, inResponse) {
-			var newuser = {"name": user.name, "password": user.password};
-			server.loginUser(newuser, function(loginSender, loginResponse) {
-				preferences.setToken({'x_key': inResponse._id, 'access_token': loginResponse.token});
-			});
+			if(!user.beforeSignup) {
+				var newuser = {"name": user.name, "password": user.password};
+				server.loginUser(newuser, function(loginSender, loginResponse) {
+					preferences.setToken({'x_key': inResponse._id, 'access_token': loginResponse.token});
+				});
+			}
 			if (response) response(inSender, inResponse);
 		});
 		ajax.error(function(inResponse) {