[clang-tidy] [dataflow] Cache reference accessors for bugprone-unchecked-optional-access
#128437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: update release notes and |
BaLiKfromUA
commented
Feb 23, 2025
| StorageLocation &Loc = | ||
| State.Lattice.getOrCreateConstMethodReturnStorageLocation( | ||
| *RecordLoc, DirectCallee, State.Env, [&](StorageLocation &Loc) { | ||
| // no-op |
There was a problem hiding this comment.
not sure if anything should be here so decided to make it no-op for now
BaLiKfromUA
commented
Feb 23, 2025
|
|
||
| bool isReference = | ||
| DirectCallee->getReturnType().getTypePtr()->isReferenceType(); | ||
| if (isReference) { |
There was a problem hiding this comment.
maybe this check is redundant
BaLiKfromUA
commented
Feb 23, 2025
| } | ||
|
|
||
| TEST_P(UncheckedOptionalAccessTest, | ||
| ConstRefToOptionalSavedAsTemporaryVariable) { |
There was a problem hiding this comment.
added this test to check that the existing workaround still works. maybe redundant test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126283
Extending #112605 to cache const getters which return references.
This should fix false positive cases when we check optional via the chain of const getter calls.