Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM WoA buildbots for better coverage #252

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

omjavaid
Copy link
Contributor

This updates LLVM WoA bots with following changes:

  1. Do not run stage1 testing on 2 stage clang bot.
  2. Remove redundant workers.
  3. Remove -DCOMPILER_RT_BUILD_PROFILE=OFF
  4. Add compiler-rt to single stage bot
  5. Set clean=False for the 2stage bots
  6. Set "-DCLANG_DEFAULT_LINKER=lld" for all WoA bots

This updates LLVM WoA bots with following changes:
1) Do not run stage1 testing on 2 stage clang bot.
2) Remove redundant workers.
3) Remove -DCOMPILER_RT_BUILD_PROFILE=OFF
4) Add compiler-rt to single stage bot
5) Set clean=False for the 2stage bots
6) Set "-DCLANG_DEFAULT_LINKER=lld" for all WoA bots
@DavidSpickett DavidSpickett changed the title Update LLVM WoA buildbots for better converage Update LLVM WoA buildbots for better coverage Oct 10, 2024
@DavidSpickett
Copy link
Contributor

Sorry I completely missed this.

Set clean=False for the 2stage bots

Does this make a difference now that we use ccache? Also we may have to switch it back to clean if #266 works out.

You can leave it in here for now though.

Copy link
Contributor

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omjavaid omjavaid merged commit 699c3ba into llvm:main Oct 17, 2024
1 check passed
DavidSpickett added a commit to llvm/llvm-project that referenced this pull request Oct 23, 2024
…n Arm

This test has been failing since https://lab.llvm.org/buildbot/#/builders/161/builds/2899,
but no change in that build caused it.

I think this has always failed but llvm/llvm-zorg#252
only recently enabled in on the bot.
omjavaid added a commit to omjavaid/llvm-zorg that referenced this pull request Oct 24, 2024
Since llvm#252 we have got increased build times on WoA build bots.
Also WoA 2 stage bot does not collapse the queue because it is
not configured to always do a clean build. This patch tries to
fix above issues.

On both single and 2 stage bots:
- Set `LLVM_TARGETS_TO_BUILD` to 'ARM;AArch64;X86'. We only care
  about these targets on windows.

On 2 stage bot:
- Set stage 1 LLVM_TARGETS_TO_BUILD to AArch64 only.
- Set extra_stage2_cmake_args which overrides extra_cmake_flags.
- Disable flang build on stage1 by setting checkout_flang=False.
- Enabled `LLVM_ENABLE_PROJECTS=flang;mlir` for stage 2.
- Switched to a clean build (`clean=True`) for collapsing queue.
- Like stage 1 set stage 2 CLANG_DEFAULT_LINKER to lld. This makes
  sure just built lld is used by just built clang as default linker.
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
…n Arm

This test has been failing since https://lab.llvm.org/buildbot/#/builders/161/builds/2899,
but no change in that build caused it.

I think this has always failed but llvm/llvm-zorg#252
only recently enabled in on the bot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants