Update Glossary.md to add links for adding terms and requesting explanations #184
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
suggested changes
Mar 26, 2024
jpienaar
reviewed
Apr 1, 2024
joker-eph
requested changes
Jun 4, 2024
|
|
||
| Don't see a term here that you think should be? | ||
| [Edit this page to add it](https://github.com/llvm/mlir-www/blob/main/website/content/getting_started/Glossary.md). | ||
| Don't know what it means? Join the [LLVM Discord](https://discord.gg/xS7Z362) and ask in the [#torch-mlir channel](https://discord.com/channels/636084430946959380/742573221882364009) |
There was a problem hiding this comment.
Why is the Torch MLIR channel mentioned here?
ScottTodd
reviewed
Oct 17, 2024
There was a problem hiding this comment.
(Flushing my review queue) Did you want to continue with this PR? It doesn't look like there's much substance here left.
- "Edit this page" is covered by the existing "edit on github button". Similar text could technically go on all website pages :p
- Join discord and torch-mlir comments are also unrelated
|
Yup! This should get closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.