-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AtenNonzeroOp via DecomposeComplexOps #3721
base: main
Are you sure you want to change the base?
Conversation
@gpetters94 does some shape-related things in his previous attempt at this op that I don't understand. I think I should maybe replicate those. Specifically:
|
Using below testcase, it seems to generate illegal aten.slice.Tensor
command line to reproduce
from the debug, one SliceTensor is illegal, since the slice dim is >= input rank.
%20 rank is 1, but the dim is also %int1
Do you have any suggestion? @renxida |
It seems the second slice tensor should happen at the zero dimension, since the strides tensor is 1-D tensor
|
on this one today while Stella looks at my shortfin thing. |
@lionsky nice catch. i'll fix this one! |
Implements part of: #3293
Uses logic by GPetters from #615
Prototyped on google colab in this notebook