-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scalarization Patterns for AtenToDtypeOp
, AtenNegOp
, AtenRemainderTensorOp
#3861
Merged
+302
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add canonicalization to remove complex dynamic shape calculations from unflatten ops whenever these could just be -1 Add lowering to arith for neg.int and remainder.int ops
zjgarvey
force-pushed
the
prop_todtype
branch
from
November 11, 2024 19:04
9a2b366
to
5bea9eb
Compare
rsuderman
requested changes
Nov 11, 2024
vivekkhandelwal1
previously requested changes
Nov 12, 2024
rsuderman
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aten.neg.int
andaten.remainder.int
to arith.aten.neg
andaten.remainder.Tensor
ops.aten.mul.int
aten.to.dtype
which relies on scalar cast ops and basic C++ casting betweendouble
andint64_t
.FoldAtenSplatPattern
aten.unflatten.int
decomposition incorrectly generating a constant size int from a dynamic shape.aten.unflatten.int
ops generated from theaten.view
canonicalization in scalarize shapes.All of these changes were necessary to unblock iree-org/iree#18899.