feat(fx-importer): support for importing fp8 model parameters #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially follows the same way how the importing of `bfloat16` is being handled.
zjgarvey
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Sorry it took a while to get around to this. It looks good to me.
I'd like to have some tests to make sure these dtypes import properly and don't regress with version bumps, but we might need to add the ml_dtypes dependency to a workflow file somewhere. If you think it is a good idea to spend some time adding tests, I think it would be best to add them before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially follows the same way how the importing of
bfloat16is being handled. Related to #2896.