crypto tests: import everything from index #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsodium has an async initialization step, which we deal with using a top-level await in the crypto package's main export:
auth/packages/crypto/src/index.ts
Line 3 in 573c17e
But some tests were importing directly from the individual modules, e.g.
auth/packages/crypto/src/test/randomKey.test.ts
Line 2 in 1463003
and this was causing a race condition that resulted in intermittent test failures in the crypto package.
This PR ensures that all tests import from
../index.js
so that libsodium is always initialized before we try to use it.Testing plan
Confirm that the crypto tests consistently pass