Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: ensure that userId and user name are unique among team members #126

Conversation

michaelkamphausen
Copy link
Contributor

I added validations to check if the userId and user name are unique when a new member is admitted. The validation fails if another team member already uses the same userId or (case-insensitive) userName. I hope it helps with #72. I confess that I haven't thought about the tricky part of concurrency though.

@HerbCaudill
Copy link
Member

Thanks, Michael! I do want to think through the concurrency issue so we can handle conflicts in a principled way, but this is an improvement over the status quo so I'll go ahead and merge it.

@HerbCaudill HerbCaudill merged commit acedb19 into local-first-web:main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants