-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Automatic-Module-Name' to all MANIFEST.MF #511
base: master
Are you sure you want to change the base?
Add 'Automatic-Module-Name' to all MANIFEST.MF #511
Conversation
Not sure about this one at the moment since compile-level and source-level is still Java 1.8. And I remember some clitches Michael mentioned I'd like to clarify first ;) |
I have no strong feeling abot one way or the other. I guess conflicts to the other PR are easy to resolve once joda-time fixes are on master. Lets keep it as it is unless the other one is done. BTW: Is there a setting in eclipse to allow Automatic-Module-Name? Maybe its worth to document it in the Dev-guilde Eclipse IDE... |
I didn't actively make these changes when making changes for the joda time update so I'm thinking the version of Eclipse I used made this change automatically (or maybe I did quick fix and didn't realize it). Apparently they do have a quick fix: |
This new attribute is required to move on to Java 9 or newer.