Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install version. #1355

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

abussy-aldebaran
Copy link

This will install libcrocoddyl.so.2.2.0 as a binary and libcrocoddyl.so as a symlink, instead of just libcrocoddyl.so as a binary.

Copy link
Collaborator

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, however I don't see why you consider this a "fix".
Was anything "broken" ? Did you have an error message ?

@abussy-aldebaran
Copy link
Author

Yes, sorry. It's a fix for my yocto build, which fails because of this during packaging. However, I just learned that I could disable the error in the recipe. So feel free to discard this PR if you want.
If not, do you have a suggestion of rewording ?

Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduced in this PR are making to fail our examples in Conda jobs. Before merging this, we need to fix it.

@abussy-aldebaran
Copy link
Author

The changes introduced in this PR are making to fail our examples in Conda jobs. Before merging this, we need to fix it.

I'll take a look at it

@abussy-aldebaran abussy-aldebaran changed the title Fix install version. Add install version. Mar 13, 2025
@abussy-aldebaran
Copy link
Author

I reworded the PR.
Concerning the macOS build, I couldn't reproduce the error. I tried on an old MacBook though...

MacBook Pro (Retina, Early 2015)
macOS Monterey 12.7.6
Xcode 13.4.1

@cmastalli
Copy link
Member

Hi @abussy-aldebaran!

I just merged a PR that fixes our NIX Mac PR. Could you rebase your branch and ping me?

This will install libcrocoddyl.so.2.2.0 as a binary and libcrocoddyl.so
as a symlink, instead of just libcrocoddyl.so as a binary.
@abussy-aldebaran
Copy link
Author

@cmastalli done !

@cmastalli cmastalli merged commit 1c2fd63 into loco-3d:devel Mar 13, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants