-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install version. #1355
Add install version. #1355
Conversation
1788ada
to
f40080e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, however I don't see why you consider this a "fix".
Was anything "broken" ? Did you have an error message ?
Yes, sorry. It's a fix for my yocto build, which fails because of this during packaging. However, I just learned that I could disable the error in the recipe. So feel free to discard this PR if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes introduced in this PR are making to fail our examples in Conda jobs. Before merging this, we need to fix it.
I'll take a look at it |
f40080e
to
9a23d22
Compare
I reworded the PR.
|
I just merged a PR that fixes our NIX Mac PR. Could you rebase your branch and ping me? |
This will install libcrocoddyl.so.2.2.0 as a binary and libcrocoddyl.so as a symlink, instead of just libcrocoddyl.so as a binary.
9a23d22
to
e2b75b9
Compare
@cmastalli done ! |
This will install libcrocoddyl.so.2.2.0 as a binary and libcrocoddyl.so as a symlink, instead of just libcrocoddyl.so as a binary.