This repository was archived by the owner on Sep 16, 2023. It is now read-only.
Fix behavior change for createCompounder when deburring is not enabled #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the problem through Webpack non-deterministic builds as described in #162, this pull request fixes a change in behavior in all functions that depend on
createCompounder
whendeburring
is not enabled:camelCase
kebabCase
lowerCase
snakeCase
startCase
upperCase
Assuming these functions are expected to work with non-String arguments, such as
null
or{}
, since that's the behavior in the full build of the library.The Bug 🐞
When
deburring
is disabled,deburr
will be replaced withidentity
, failing to coerce the argument to aString
as it normally would, socreateCompounder
fails when callingreplace
if the function was called with any non-String argument.The Fix 🔨
Substitute
deburr
withtoString
instead whendeburring
is disabled. This will ensure any arguments are coerced as usual, but no regex replacement will occur.