Fix Azure OpenAI chat model baseURL construction logic. #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that when using Azure OpenAI as the chat model provider, the generated URL is incorrect. I modified the code to use the user-provided endpoint URL, and it worked correctly for me.
However, there is still an issue when using Azure OpenAI as the embedding model provider. Unfortunately, I am not familiar enough with this part of the script to rewrite the URL logic. I can, however, provide some error details: the script generates a default URL in the format
https://{model_name}xx.openai.xx, which is not the correct format for the Azure OpenAI API. I strongly recommend using the user-provided endpoint URL instead of constructing the URL programmatically based on rules.