-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: do not display backup size of 0 for in-progress backup #892
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant SnapshotIcon
participant FormatMib
UI->>SnapshotIcon: Render SnapshotIcon
SnapshotIcon->>SnapshotIcon: Check if backupStatusObject.size or snapshotObject.size > 0
alt Condition met
SnapshotIcon->>FormatMib: Call formatMib(size)
FormatMib-->>SnapshotIcon: Return formatted size
SnapshotIcon-->>UI: Display size paragraph with formatted value
else Condition not met
SnapshotIcon-->>UI: Display without size
end
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
{(backupStatusObject?.size || snapshotObject?.size) > 0 && ( | ||
<p className="snapshot-name"> | ||
Size: {backupStatusObject?.size ? formatMib(backupStatusObject.size) : formatMib(snapshotObject.size)} | ||
</p> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the backup size is really 0 after completing the backup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what scenario can the backup size be 0?
Signed-off-by: Yi-Ya Chen <[email protected]>
What this PR does / why we need it
Issue
[IMPROVEMENT] Do not display backup size of 0 for in-progress backup #9783
Test Result
Size: 0 Bi
Screen.Recording.2025-03-14.at.10.17.47.AM.mov
Additional documentation or context
N/A
Summary by CodeRabbit