DM-48316: Add model PSF ellipticity thresholds in single frame processing #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to guard against irregular PSF shapes (e.g the trefoil, trailed, kettlebell, etc. shapes often encountered during commissioning), impose thresholds on the measured PSF model on its ellipticity as well as its unnormalized ellipticity, defined as hypot(Ixx - Iyy, 2Ixy). These thresholds can be set per band and a fallback value is used if the current band is not included in the threshold config dict. Detectors where the initial PSF model has values exceeding these thresholds raise an UnprocessableDataError such that downstream tasks know to skip them (and thus do not result in processing failures that would waste human time chasing down). The values here have been conditioned on the LSSTComCam DP1 dataset and do a good job at only excludeing truly "bad" PSFs. The cuts are intentionally somewhat conservative to allow SFP to continue on PSFs that are more in the "iffy" catagory. For science cases that require strict quality of the PSF, further cuts can be made on the detectors that are included in coaddition.
laurenam
force-pushed
the
tickets/DM-48316
branch
from
6f3262f to
04046fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.