Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdown): add animations on rotary event #7271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(dropdown): add animations on rotary event #7271

wants to merge 2 commits into from

Conversation

AndreCostaaa
Copy link

Tackles #6926 by enabling animation when selecting the dropdown position following a LV_EVENT_ROTARY event

@AndreCostaaa AndreCostaaa changed the title feat(dropdown): add animations on select position feat(dropdown): add animations on rotary event Nov 9, 2024
liamHowatt
liamHowatt reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling the issue!

src/widgets/dropdown/lv_dropdown.c Outdated Show resolved Hide resolved
src/widgets/dropdown/lv_dropdown.c Show resolved Hide resolved
kisvegabor
kisvegabor approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamHowatt liamHowatt liamHowatt approved these changes

@kisvegabor kisvegabor kisvegabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreCostaaa @kisvegabor @liamHowatt