Add patch for libheif #6
Conversation
| # TODO: how to do configure vvdec cleanly? | ||
| find_package(Threads REQUIRED) | ||
| - find_package(vvdec 2.3.0) | ||
| + find_package(vvdec 3.0.0) |
There was a problem hiding this comment.
I was wondering about this, but why do you need to bump the version number? Does it cause a configuration error?
There was a problem hiding this comment.
The vvdec cmake returns error if major version mismatch.
IIRC it does not make configuration fail, but the vvdec will not be linked.
There was a problem hiding this comment.
I see your issue on libheif's repo. I'm not really sure where the blame lays, I guess vvdec is being really paranoid about major version changes.
| endif() | ||
|
|
||
| - find_package(Brotli) | ||
| + # find_package(Brotli) |
There was a problem hiding this comment.
Is this because of the whole brotlicommon, brotlienc, and brotlidec linking order issues?
There was a problem hiding this comment.
Yes...
Shall I add comment about that?
Or can you help to figure out a solution?❤
There was a problem hiding this comment.
iirc, I had a few issues regarding brotli and libjxl due to linking issues, may need to look at that to figure out more.
| -find_package(TIFF) | ||
| +# find_package(TIFF) |
There was a problem hiding this comment.
What's the error with this one? linking issues?
There was a problem hiding this comment.
Yes, and there's also "built tiff" vs. "pacman tiff" situation.
"built tiff" causes configuration failure, "pacman tiff" has linking issues.
No description provided.