WIP: separate interface into immutable and mutable #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiya
reviewed
Oct 22, 2019
| @@ -65,7 +66,7 @@ class M3OpenCensusTracer internal constructor( | |||
|
|
|||
| override fun processIncomingHttpRequest(request: HttpRequestInfo): HttpRequestSpan = httpRequestTracer.processRequest(request) | |||
|
|
|||
| override fun processOutgoingHttpRequest(request: HttpRequestInfo): HttpRequestSpan = httpRequestTracer.processClientRequest(request) | |||
| override fun processOutgoingHttpRequest(request: MutableHttpRequestInfo): HttpRequestSpan = httpRequestTracer.processClientRequest(request) | |||
There was a problem hiding this comment.
Advanced recommendation: How about renaming existing HttpRequestInfo to IncomingHttpRequestInfo and also rename MutableHttpRequestInfo to OutgoingHttpRequestInfo ?
And make common super-interface HttpRequestInfo to avoid copy-and-paste (IncomingHttpRequestInfo extends HttpRequestInfo and OutgoingHttpRequestInfo extends HttpRequestInfo).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough sketch of
HttpRequestInfoseparation discussed on #4 (comment) .Change summary is the following:
HttpRequestInfoandMutableHttpRequestInfo, the latter is for mutating headersSpringHttpRequestInfo::trySetHeaderreceives only acceptable header names, the function should not be accept some headersIs the design good? Please send me a feedback.