Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Merge Conflict (2.4-develop) #114

Merged
merged 977 commits into from
Jan 14, 2025
Merged

Conversation

mage-os-ci
Copy link
Contributor

This PR was automatically generated: a human is required.

Auto-merging app/code/Magento/Catalog/Test/Unit/Model/ProductOptions/Config/_files/invalidProductOptionsXmlArray.php
CONFLICT (content): Merge conflict in app/code/Magento/Catalog/Test/Unit/Model/ProductOptions/Config/_files/invalidProductOptionsXmlArray.php
Auto-merging app/code/Magento/Catalog/Test/Unit/Model/ProductTypes/Config/_files/invalidProductTypesXmlArray.php
CONFLICT (content): Merge conflict in app/code/Magento/Catalog/Test/Unit/Model/ProductTypes/Config/_files/invalidProductTypesXmlArray.php
Auto-merging composer.json
Auto-merging dev/tests/integration/framework/Magento/TestFramework/ApplicationStateComparator/_files/state-skip-list.php
Automatic merge failed; fix conflicts and then commit the result.

Adiglo70550 and others added 30 commits December 10, 2024 16:58
…ing cart after the session is expired

Added "persistentLogoutClearDisable" step to MAGETWO-95118 mftf test
[Bengals] Functional Tests Mainline Deployment
…ountry is selected with entering zip code and verfiy without entering zipcode

Added pr_exclude value for all test
… and excluding virtual products

Testcase Updated
Implement extensible data re-encryption mechanism and decommission existing one
…into functional-test-automation-deployment
… when single store mode is enabled in the configuration

deleted file
Added pr_exclude as it is a third party test
…o when single store mode is enabled in the configuration.

Renamed the testcase name from ChangeFrontendLogoWithSingleStoreModeTest.xml to AdminChangeFrontendLogoWithSingleStoreModeTest.xml
…frontend logo when single store mode is enabled in the configuration
…eployment

[Bengals] Functional Tests Mainline Deployment
@fballiano
Copy link
Contributor

@rhoerr @sprankhub could you please check the conflicts? it's only 2 files (luckily) and I think we should leave "our" version of those changes

@rhoerr
Copy link
Contributor

rhoerr commented Jan 3, 2025

The first file was changed in e53dbb6#diff-d1d04d0b346755fc707f0fd0bf0c9ff072af9b1080bc3df1f1822a3aad1039dd to fix unit test failures
We changed it in
e53dbb6#diff-d1d04d0b346755fc707f0fd0bf0c9ff072af9b1080bc3df1f1822a3aad1039dd also to fix unit test failures

The second file was changed in 8e37779 to fix unit test failures
We changed it in
e53dbb6#diff-d1d04d0b346755fc707f0fd0bf0c9ff072af9b1080bc3df1f1822a3aad1039dd also to fix unit test failures

In both cases, the intent is the same and I assume both versions work. I'm going to go with the upstream versions so this isn't divergent in the future.

@rhoerr
Copy link
Contributor

rhoerr commented Jan 3, 2025

I can't directly resolve them because of 2.4-develop-upstream being a protected branch. Will have to do it as mage-os-ci later unless someone handles it first.

@fballiano
Copy link
Contributor

can't make it either, no privileges

@mage-os-ci mage-os-ci marked this pull request as ready for review January 14, 2025 01:15
@mage-os-ci mage-os-ci requested a review from a team as a code owner January 14, 2025 01:15
@mage-os-ci mage-os-ci merged commit f6d567c into 2.4-develop Jan 14, 2025
6 of 9 checks passed
@mage-os-ci mage-os-ci deleted the 2.4-develop-upstream branch January 14, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.