Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Upload New Image button not working in Pagebuilder when trying to change image #39576

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

manan-patel1
Copy link

Preconditions (*)

  1. Magento version : 2.4 - develop
  2. Magento version : 2.4.7-p3

Description (*)

In Adminside, The image is uploaded for the first time in pagebuilder. When we try to change the uploaded image then the 'Upload New Image' button does not work.

Related Issue

Fixes #39063

Manual testing scenarios (*)

  1. Edit a product
  2. Scroll to and expand content section
  3. Click Edit with Page Builder
  4. Insert a row
  5. Add Image media element to the row
  6. Hover over "Image" element - "Upload Image" / "Select from Gallery" popup should appear.
  7. Click on "Upload Image"
  8. Again hover on the uploaded image - "Upload New Image" / "Select from Gallery" popup should
    appear.
  9. Click on "Upload New Image" then you see that the button is not clickable.
issue-reproduce.mp4

Expected result

You should be able to upload new images after clicking "Upload New Image".

Actual result

No response when clicking "Upload New Image".

Additional Information

File: magento/module-ui/view/base/web/js/form/element/file-uploader.js

In Magento 2.4.7, the jQuery file uploader (jquery.fileuploader.js) has been replaced with Uppy (uppy.min.js), leading to changes in the JS logic of file-uploader.js. The replaceInputTypeFile function binds the click event only to the "Upload Image" button inside .pagebuilder-image-empty-preview (used when no image is uploaded). However, it misses the button in the toolbar that appears on hover for content types like Banner, Slider, and Image (when an image is already uploaded).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jan 28, 2025

Hi @manan-patel1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@manan-patel1
Copy link
Author

@magento run all tests

@manan-patel1 manan-patel1 changed the title Fixed new image uploading issue in pagebuilder Fixed Upload New Image button not working in Pagebuilder when trying to change image Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] PageBuilder Banner element - upload new image button is not responding
1 participant